gpodder.download: Ignore non-ASCII content-disposition header (bug 2059)

gpodder · Jan 15, 2016 · 2fab357 · 2fab357
1 parent 1e2cc73
commit 2fab357
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/src/gpodder/download.py b/src/gpodder/download.py
@@ -820,8 +820,13 @@ def run(self):
                             real_url, os.path.basename(self.filename))
 
             # Look at the Content-disposition header; use if if available
-            disposition_filename = get_header_param(headers, \
-                    'filename', 'content-disposition')
+            disposition_filename = get_header_param(headers, 'filename', 'content-disposition')
+
+            try:
+                disposition_filename.decode('ascii')
+            except:
+                logger.warn('Content-disposition header contains non-ASCII characters - ignoring')
+                disposition_filename = None
 
             # Some servers do send the content-disposition header, but provide
             # an empty filename, resulting in an empty string here (bug 1440)