Skip to content

Commit

Permalink
Remove gstreamer track length detection (bug 1316)
Browse files Browse the repository at this point in the history
This is just too crashy :/
  • Loading branch information
thp committed Apr 6, 2011
1 parent 189c03a commit 4d9ad45
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 91 deletions.
1 change: 0 additions & 1 deletion README
Expand Up @@ -43,7 +43,6 @@

* python-gpod (libgpod's Python bindings)
* At least one of the following packages:
- python-gst0.10 (GStreamer Python bindings)
- mplayer (recommended for video podcasts)
- python-eyed3 (eyeD3 library)

Expand Down
69 changes: 0 additions & 69 deletions src/gpodder/gstreamer.py

This file was deleted.

16 changes: 0 additions & 16 deletions src/gpodder/model.py
Expand Up @@ -27,7 +27,6 @@
from gpodder import util
from gpodder import feedcore
from gpodder import youtube
from gpodder import gstreamer

from gpodder.liblogger import log

Expand Down Expand Up @@ -857,21 +856,6 @@ def on_downloaded(self, filename):
self.is_played = False
self.length = os.path.getsize(filename)

if not self.total_time:
try:
length = gstreamer.get_track_length(filename)
if length is not None:
length = int(length/1000)
log('Detected media length: %d seconds', length, \
sender=self)
self.total_time = length
self.db.save_episode(self)
self.db.commit()
return
except Exception, e:
log('Error while detecting media length: %s', str(e), \
sender=self)

self.db.save_downloaded_episode(self)
self.db.commit()

Expand Down
5 changes: 0 additions & 5 deletions src/gpodder/sync.py
Expand Up @@ -27,7 +27,6 @@
from gpodder import util
from gpodder import services
from gpodder import libconverter
from gpodder import gstreamer

from gpodder.liblogger import log

Expand Down Expand Up @@ -128,10 +127,6 @@ def open_device(config):
return None

def get_track_length(filename):
length = gstreamer.get_track_length(filename)
if length is not None:
return length

if util.find_command('mplayer') is not None:
try:
mplayer_output = os.popen('mplayer -msglevel all=-1 -identify -vo null -ao null -frames 0 "%s" 2>/dev/null' % filename).read()
Expand Down

0 comments on commit 4d9ad45

Please sign in to comment.